[OpenWrt-Devel] [PATCH 3/3] mac80211: ath10k: reset chip after supported check

[Ben Greear]

On 4/1/19 2:07 PM, Tom Psyborg wrote:
> On 01/04/2019, Ben Greear <greearb at candelatech.com> wrote:
>> On 4/1/19 1:32 PM, Tomislav Požega wrote:
>>> When chip reset is done before the chip is checked if supported
>>> there will be crash. Previous behaviour caused bootloops on
>>> Archer C7 v1 units, this patch allows clean device boot without
>>> excluding ath10k driver.
>>
>> Did you try the patch that Michal posted that checks the chip version
>> ID and so might be a good and safe fix for all chips?
> 
> please provide link. i did not get such patch in my inbox

I forwarded it separately.  If that fixes the problem, then I think it has
a decent change of being accepted upstream (as well as into my ath10k-ct
repo).

>> If you want to put in a hack like this for a particular platform, maybe
>> make it specific to that one platform so you don't risk instability on
>> a wide range of systems?
> 
> since other devices use ath10k-ct i decided to switch to ath10k only
> on this specific platform so it shouldn't be a problem

Just because some platforms use ath10k-ct as a default doesn't mean that users
don't change the defaults and use the stock driver.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel