[OpenWrt-Devel] [PATCH 1/3] brcm63xx: VH4032N: fix issues with pinctrl

Daniel Gonzalez Cabanelas dgcbueu at gmail.com
Tue Nov 13 19:47:40 EST 2018


The Observa VH4032N has some troubles related to the pinctrl since the adoption
of this driver:  

  - missing pinctrl avoiding to operate the wifi correctly
  - missing pinctrls avoiding the LAN LEDs to be hardware controlled
  - the GPIO hog doesn't work, and as a result of this the onboard USB HUB isn't 
    pulled out of reset. Also the GPIO chip fails to register and the LEDs won't work.

Fix it by adding the missing pincontrols. And workaround the USB HUB issue
by pulling it out of reset using a fake LED on the GPIO pin.

Leave the GPIO hog code disabled until this feature works with the
brcm63xx GPIO pinctrl.

Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu at gmail.com>
---
This patch superseeds: "brcm63xx: VH4032N: add missing pinctrl"

 target/linux/brcm63xx/dts/vh4032n.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/target/linux/brcm63xx/dts/vh4032n.dts b/target/linux/brcm63xx/dts/vh4032n.dts
index 1296fbf..156d103 100644
--- a/target/linux/brcm63xx/dts/vh4032n.dts
+++ b/target/linux/brcm63xx/dts/vh4032n.dts
@@ -68,16 +68,27 @@
 			label = "VH4032N:red:voice";
 			gpios = <&pinctrl 26 1>;
 		};
+		/* Use this workaround until the gpio-hog works again */
+		usb_hub_reset {
+			label = "usb-hub-reset-gpio";
+			gpios = <&pinctrl 27 0>;
+			default-state = "on";
+		};
 	};
 };
 
 &pinctrl {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pci &pinctrl_ephy0_led &pinctrl_ephy1_led
+		     &pinctrl_ephy2_led &pinctrl_ephy3_led>;
+#if 0
 	usb_hub_reset {
 		gpio-hog;
 		gpios = <27 0>;
 		output-high;
 		line-name = "usb-hub-reset-gpio";
 	};
+#endif
 };
 
 &pflash {
-- 
2.6.4



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list