[OpenWrt-Devel] [PATCH 2/4 RFCv2] net: dsa: Add bindings for Realtek SMI DSAs

Florian Fainelli f.fainelli at gmail.com
Tue May 29 15:30:41 EDT 2018

On 05/28/2018 10:47 AM, Linus Walleij wrote:
> The Realtek SMI family is a set of DSA chips that provide
> switching in routers. This binding just follows the pattern
> set by other switches but with the introduction of an embedded
> irqchip to demux and handle the interrupts fired by the single
> line from the chip.
> This interrupt construction is similar to how we handle
> interrupt controllers inside PCI bridges etc.
> Cc: Antti Seppälä <a.seppala at gmail.com>
> Cc: Roman Yeryomin <roman at advem.lv>
> Cc: Colin Leitner <colin.leitner at googlemail.com>
> Cc: Gabor Juhos <juhosg at openwrt.org>
> Cc: Florian Fainelli <f.fainelli at gmail.com>
> Cc: devicetree at vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---

> +
> +	mdio {
> +		compatible = "realtek,smi-mdio", "dsa-mdio";

You should drop the "dsa-mdio" compatible string here since it both non
documented and not matched either.

Other than that, this looks great, with that fixed:

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list