[OpenWrt-Devel] [PATCH v2] build: download code from github using archive API

Jo-Philipp Wich jo at mein.io
Fri Jun 29 01:29:00 EDT 2018


> It seems to be like that script does things even if the tarballs are
> already existing locally.

the main problem I see is that you moved the download method detection
from inline make code into the external Python script ... this will
cause a lot of overhead as during the metadata scanning, your script is
getting executed once for every Makefile which can easily be several
thousand times with feeds installed.

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20180629/ffc2c389/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list