[OpenWrt-Devel] [PATCH v2 2/2] kernel: atm: pppoatm fix vc-mux connection failures

David Woodhouse dwmw2 at infradead.org
Sat Jun 16 06:59:14 EDT 2018



On Sat, 2018-06-16 at 09:48 +0000, David Woodhouse wrote:
> 
> > Backport a hot off the press upstream kernel ATM fix:
> >
> > Preserve value of skb->truesize when accounting to vcc
> >
> > "There's a hack in pskb_expand_head() to avoid adjusting skb->truesize
> > for certain skbs. Ideally it would cover ATM too. It doesn't. Just
> > stashing the accounted value and using it in atm_raw_pop() is probably
> > the easiest way to cope."
> >
> > The issue was introduced in upstream by:
> >
> > commit 14afee4b6092fde451ee17604e5f5c89da33e71e
> > Author: Reshetova, Elena <elena.reshetova at intel.com>
> > Date:   Fri Jun 30 13:08:00 2017 +0300
> >
> >     net: convert sock.sk_wmem_alloc from atomic_t to refcount_t
> >
> > Sincerest thanks to Mathias Kresin <dev at kresin.me> for debugging
> > assistance and to David Woodhouse <dwmw2 at infradead.org> for further
> > guidance, cajoling & patience in interpreting the debug I was giving him
> > and producing a fix!
> >
> > Fixes FS#1567
> 
> Is it tested with PPPoA+LLC-encaps and (more importantly) PPPoE+BR2684?
> (Please)

Ah, I see your 5am assertion that it is. Thanks again for going above
and beyond to help diagnose and fix this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5213 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20180616/882a611f/attachment.bin>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


More information about the openwrt-devel mailing list