[OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

Hannu Nyman hannu.nyman at iki.fi
Wed Jul 11 05:44:38 EDT 2018

Kevin Darbyshire-Bryant wrote:
> Really not convinced I agree with the "patch 335 removes the whole code 
> block where that one line changed in upstream”.

You are right.
The corresponding addition needs to be done for the lines replacing the 
removed lines:
  932 + if (filter && filter->table[0] &&
should likely be
  932 + if (filter && filter->table &&
matching the change done upstream.

In my comment I overlooked the part where we add back similar lines :-(

(the refresh patch only notices the need to refresh the upstream lines, 
but does not know about out own additions.)

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list