[OpenWrt-Devel] [PATCH 1/6] uclient-fetch: Check for nullpointer returned by open_output_file

[John Crispin]

On 18/02/18 04:36, Tobias Schramm wrote:
> Signed-off-by: Tobias Schramm <tobleminer at gmail.com>
> ---
>   uclient-fetch.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/uclient-fetch.c b/uclient-fetch.c
> index 6961d94..46f9b3d 100644
> --- a/uclient-fetch.c
> +++ b/uclient-fetch.c
> @@ -122,6 +122,11 @@ static int open_output_file(const char *path, uint64_t resume_offset)
>   		}
>   	} else {
>   		filename = uclient_get_url_filename(path, "index.html");
> +		if(!filename) {
> +			ret = -ENOMEM;
> +			goto done;

should this not be goto free; ?

     John

> +		}
> +
>   		output_file = filename;
>   	}
>   
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel