[OpenWrt-Devel] [PATCH firewall3 2/2] utils: Free args in __fw3_command_pipe()

[Hauke Mehrtens]

args was not freed after leaving this function.

Fixes Coverity issue 1412470 Resource leak

Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
 utils.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/utils.c b/utils.c
index 4f892a7..684b2c3 100644
--- a/utils.c
+++ b/utils.c
@@ -252,6 +252,7 @@ __fw3_command_pipe(bool silent, const char *command, ...)
 	switch ((pid = fork()))
 	{
 	case -1:
+		free(args);
 		return false;
 
 	case 0:
@@ -275,6 +276,7 @@ __fw3_command_pipe(bool silent, const char *command, ...)
 	}
 
 	pipe_fd = fdopen(pfds[1], "w");
+	free(args);
 	return true;
 }
 
-- 
2.19.2


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel