[OpenWrt-Devel] [PATCH 1/4] mvebu: add Turris Omnia LED support

Petr Štetiar ynezz at true.cz
Sat Dec 15 15:32:00 EST 2018

[Adding Tomas to the Cc loop]

Klaus Kudielka <klaus.kudielka at gmail.com> [2018-12-15 12:33:46]:

> This is what I would do: Split this patch (1/4) into two. One for driver &
> Makefile, one for the device tree extension.

I'm sorry, but I think, that this is not going to be that easy :-) In the
almost two year old discussion[1] under the patch which has added support for
Omnia to the kernel Tomas wrote:

 It definitely needs some cleanup and it adds non-standard features (main PWM
 for all LEDs, autonomous blink mode, colors) via custom /sys files, which I
 suspect that is not going to be acceptable for upstream.

I would probably write an email to the linux-leds mailing list, explained the
situation and asked there for the help.  Maybe it could be converted to the
new LED pattern trigger[2]?

> Submit both patches to: linux-leds; cc: linux-kernel; cc: devicetree.

There's a script for this `scripts/get_maintainer.pl 000*.patch`, more details
in the submitting patches documentation[3].

1. https://patchwork.kernel.org/patch/9442351/#19851409
2. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6fd577cd4b257ce5cb761adcdedeea55501d84d9
3. https://www.kernel.org/doc/html/latest/process/submitting-patches.html

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list