[OpenWrt-Devel] [PATCH 1/8] kernel: add DT binding support to the fit parser

[John Crispin]

On 10/12/2018 16:47, Piotr Dymacz wrote:
> Hi Christian,
>
> On 09.12.2018 16:34, Christian Lamparter wrote:
>> It allows specifying default and Netgear parsers directly in the DT.
>>
>> Signed-off-by: Christian Lamparter <chunkeey at gmail.com>
>> ---
>>   .../linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_fit.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git 
>> a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_fit.c 
>> b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_fit.c
>> index f356adcd4e..b7e56fc083 100644
>> --- a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_fit.c
>> +++ b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_fit.c
>> @@ -120,9 +120,15 @@ mtdsplit_fit_parse(struct mtd_info *mtd,
>>       return 2;
>>   }
>>   +static const struct of_device_id mtdsplit_fit_of_match_table[] = {
>> +    { .compatible = "openwrt,fit-firmware" },
>
> Shouldn't that be "denx,fit", same as in case of "denx,uimage"? AFAIK, 
> FIT format also comes from U-Boot and it's not OpenWrt specific 
> (please, correct me if I'm wrong here).
>
i was about to ask the same. a owrt prefix means we have to worry about 
it in the future and we dont want that....

     John


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel