[OpenWrt-Devel] [LEDE-DEV] [PATCH 8/9] ramips: add Devolo WiFi Repeater (mt2681)
wigyori at uid0.hu
Mon Oct 23 04:13:42 EDT 2017
On Mon, 23 Oct 2017, Mathias Kresin wrote:
> 22.10.2017 22:21, Zoltan HERPAI:
>> This is pretty much the same as the ALL0256N-8M but with different LED
>> Based on Matt Jenkins' patch, with additional reworks.
>> Signed-off-by: Zoltan HERPAI <wigyori at uid0.hu>
> Hey Zoltan,
> I'm not sure how proceed with the patch. It has bunch of issues and if
> someone else would send this patch I wouldn't merge it as it is.
> Some of the issues are:
> - missing hardware description in the commit message
> - missing initial install instructions in the commit message
> - bad board naming (the name looks like a mediatek reference board)
> - wrong use of wifi led
> - outdated syntax in the dts
> Since you most likely do not have this board, I'm not sure if it does make
> any sense to do the full review => request changes cycle.
> Any suggestions how to proceed with this one?
Correct, I don't have the hardware, and the HW descriptions I've found on
google are misleading. I'm leaning more towards dropping this, and if
someone wants support for it, he/she can prep the patch correctly.
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel