[OpenWrt-Devel] [PATCH netifd] device: Don't process link events anymore in device user specific callback handlers

Matthias Schiffer mschiffer at universe-factory.net
Thu May 5 16:17:13 EDT 2016

On 11/02/2015 11:16 AM, Hans Dedecker wrote:
> Set link_state for all device types via the device_set_link API as all devices are registered
> in the device tree list making it possible to always get the device via device_get.
> The decice link state parameter will now actually reflect the corresponding kernel device
> carrier state in all cases.
> Before this change a vlan/macvlan device could still have link_state enabled if an interface
> was brought down; this was the case when the parent vlan/macvlan device was still enabled as
> the netlink link_state event would be dropped for vlan/macvlan devices due to keep_link_state
> in the function cb_rtnl_event.
> Signed-off-by: Hans Dedecker <dedeckeh at gmail.com>
> ---

This patch breaks the following setup:

I have a WLAN device, and on top of it a VLAN device which uses a shell
proto. Example:

config interface 'test'
        option proto 'static'
        option ipaddr ''
        option netmask ''

config interface 'test2'
        option ifname '@test.1'
        option proto 'dhcp'

where 'test' is referenced by a wifi-iface. In this setup, wlan0.1 is
created, but the DHCP client never comes up (other shell protos yield the
same result).

If I revert this patch, or change @test.1 to wlan0.1, everything works fine.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20160505/f4558f3e/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list