[OpenWrt-Devel] [PATCH 2/5] ar71xx: Clear bits in ath79_setup_qca955x_eth_cfg
john at phrozen.org
Thu Mar 17 04:14:55 EDT 2016
On 17/03/2016 09:12, Sven Eckelmann wrote:
> On Wednesday 16 March 2016 23:47:02 John Crispin wrote:
>> this seems to break boards that rely on the bits being set byt the
>> bootloader and dont explicitly set them in the kernel. i'll revert the
>> series when i am at my work pc tomorrow.
> Thats why I've Cc'ed the authors of the other mach-*.c files so they could
> correctly set they ETH_CFG.
it should have been a RFC in that case.
> Now I have to move the function to each mach file which correctly sets the
> ETH_CFG to avoid problems caused by the u-boot presets. This requires that
> you still keep the patch for the QCA955X_ETH_CFG_* definition.
so i'll keep 1/3 and drop the other 2 ?
> Kind regards,
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel