[OpenWrt-Devel] [PATCH] package/config/netifd: Replace ifconfig/route with ip command

Daniel Dickinson openwrt at daniel.thecshore.com
Sun Jan 31 00:02:36 EST 2016

On 30/01/16 02:39 AM, Felix Fietkau wrote:
> On 2016-01-30 05:55, Daniel Dickinson wrote:
>> It worked with a /24 subnet but that might be because of defaults.  I do
>> not currently have test bed for testing other configurations.
>> I plan on setting that up once I'm back from travelling.
> Please avoid top posting, it is a rather inconvenient quoting style.

Sorry, I am forced to use Outlook for work and haven't figured out how 
to get it to do sane inline conversations, and have bad habits now 
because of that, even when using my personal Mozilla mail.

> The broken line is this:
>> ip address add $ip/${CIDR} ${broadcast:-+} dev $interface"
> It seems to me that you simply kept pieces of ifconfig syntax (the
> broadcast +) without testing if they can be used with ip. Please be more
> careful with that sort of stuff

Oh, that explains it.  I actually looked at the required command but had 
a brain fart and thought ${broadcast:-+} meant that I had the word 
broadcast on the command line (i.e. the required parameter of broadcast 
x.x.x.x for ip command), instead of reading it correctly and realizing 
it was just the variable name.


openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list