[OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

Daniel Dickinson openwrt at daniel.thecshore.com
Sun Jan 10 04:47:05 EST 2016

Ok, if this is one I just sent, that makes no sense; git does not report 
whitepace errors in git log -p, nor does the vim whitespace error 
detector you emailed me detect a whitespace error, locally.

I used git send-email so there shouldn't be any whitepspace mangling 
issues, unless patchwork is to blame.

That would actually make a kind of sense, given how often whitespaces 
issues are the reason for patches being reject; it seems rather high, 
and I will attach the patch so that you can verify that git has the 
right thing; I used git send-email so it's unlikely that it is an error 
on the sending side.

That leaves receive-side error.  It seems likely given the line the 
error is on, that patchwork is pickier than git or the vim bit you sent 
me.  That is the 'offending' line is a shell script that happens to have 
8 spaces instead of tab.  Methinks this is not a relevant thing to 
complain about in a shell script; also I wonder whether it would do the 
same with with e.g. Python?  I suspect patchwork is applying Makefile 
rules to all patches, which is just wrong.

That seems to me to be not particularly useful and creates a situation 
where users don't have any reliable means of determining if there are 
whitespace error (according to patchwork) in their patches.



On 10/01/16 03:37 AM, John Crispin wrote:
> On 10/01/2016 08:16, openwrt at daniel.thecshore.com wrote:
>> +        else
> whitespace error
>> +		local curtime="$(date +%s)"
>> +		lo

More information about the openwrt-devel mailing list