[OpenWrt-Devel] [PATCH 1/1] [DEV-1329] use NTP server received via DHCP

Bastian Bittorf bittorf at bluebottle.com
Thu Jan 7 08:42:05 EST 2016

* Amine Aouled Hamed <amine.ahd at gmail.com> [07.01.2016 14:37]:
> > please check if any interface is in DHCP-mode
> > and has a chance to get an NTP, otherwise return.
> question: Why would we need to return if there aren't interface in DHCP
> mode? the static list is always used and for DHCP it is left to the user to
> add that option in etc/config/system. I think it is safe to assume if the
> user chooses to use the DHCP option then there will be at least one
> interface in DHCP mode?

when looking at the present code, it
returns when the static list is empty.

maybe it's a rare condition, but your code
changes the behavior. for now ignore this
and polish the rest, lets see what the others say.

bye, bastian
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list