[OpenWrt-Devel] [PATCH] [ar71xx] Support for Ubiquiti UniFi AP AC LITE

Felix Fietkau nbd at openwrt.org
Tue Jan 5 05:43:02 EST 2016

On 2016-01-05 10:37, p.wassi at gmx.at wrote:
>> On 2016-01-03 22:30, Felix Fietkau wrote:
>> The additions to the mach file in the patch seem to be free of
>> dependencies on definitions from other ubnt boards - please move them to
>> a new mach-*.c file instead of patching them in.
>> - Felix
> Ah, ok. Then where should the changes to the mach-file go?
> Is /target/linux/ar71xx/files/arch/mips/ath79/mach-ubnt-unifiac.c ok?
> The intention to include it into the existing one arised, as all ubnt-devices
> are in just two mach-files. However, I've just noticed that for e.g. TP-Link
> devices nearly every device has its own mach-file.
People just kept adding to the ubnt mach file because there was
something there already (and there was some code sharing too), whereas
other devices were usually kept separate anyway.
I'd like to make sure that all future devices get their own mach files,
since that's easier to maintain.
At some point, all of this mess is going away anyway when we get proper
device tree support.

- Felix
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list