[OpenWrt-Devel] [PATCH] CC: ar71xx: add support for the TP-LINK TL-WR1043ND v3

Sven Roederer devel-sven at geroedel.de
Sun Feb 7 08:02:02 EST 2016


you are right regarding the old-style vs. new-style. I have seen this, but 
forgot about. I'll fix this with a new patch.

The Kconfig-stuff is indeed only cosmetic, but as is will not break anything I 
think it's ok. There might be no general rule if all models should be listed 
or just some examples. It may depend on the number of models for this board 
and personal mood.

I prefer upstreaming working patches, to have others taking advantage of this 
work more easily.


Am Sunday 07 February 2016, 09:00:19 schrieben Sie:
> This looks wrong. You are adding new-style definitions for all revisions
> of the WR1043ND without removing the old-style definitions.

> The Kconfig change is not necessary at all, these strings are never seen
> by humans anyways (unless you use kernel_menuconfig or similar).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20160207/8b177268/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list