[OpenWrt-Devel] [PATCH] [scripts] avoid hard-coded path in sha-bang

e196819 at hotmail.com e196819 at hotmail.com
Thu Apr 28 08:02:31 EDT 2016


Hi John,

I cannot figure out the slang words you mentioned.
I'm not a English native speaker...
Could you explain more about that?


On Mon, Apr 25, 2016 at 03:17:47PM +0200, John Crispin wrote:
> please avoid using slang words and add "scripts:" as a subject prefix
> 
> 
> 
> On 22/04/2016 11:06, Iblis Lin wrote:
> > Signed-off-by: Iblis Lin <e196819 at hotmail.com>
> > ---
> >  scripts/brcmImage.pl      | 2 +-
> >  scripts/deptest.sh        | 2 +-
> >  scripts/feeds             | 2 +-
> >  scripts/mkits.sh          | 2 +-
> >  scripts/pad_image         | 2 +-
> >  scripts/redboot-script.pl | 2 +-
> >  scripts/remote-gdb        | 2 +-
> >  7 files changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/scripts/brcmImage.pl b/scripts/brcmImage.pl
> > index 9a3acb4..60a59f2 100755
> > --- a/scripts/brcmImage.pl
> > +++ b/scripts/brcmImage.pl
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/perl
> > +#!/usr/bin/env perl
> >  #
> >  #    Copyright (C) 2009	Henk Vergonet <Henk.Vergonet at gmail.com>
> >  #
> > diff --git a/scripts/deptest.sh b/scripts/deptest.sh
> > index 047a0ce..03da9f5 100755
> > --- a/scripts/deptest.sh
> > +++ b/scripts/deptest.sh
> > @@ -1,4 +1,4 @@
> > -#!/bin/bash
> > +#!/usr/bin/env bash
> >  #
> >  # Automated OpenWrt package dependency checker
> >  #
> > diff --git a/scripts/feeds b/scripts/feeds
> > index 79b5284..2b88eb8 100755
> > --- a/scripts/feeds
> > +++ b/scripts/feeds
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/perl
> > +#!/usr/bin/env perl
> >  use Getopt::Std;
> >  use FindBin;
> >  use Cwd;
> > diff --git a/scripts/mkits.sh b/scripts/mkits.sh
> > index 6b5100e..8857996 100755
> > --- a/scripts/mkits.sh
> > +++ b/scripts/mkits.sh
> > @@ -1,4 +1,4 @@
> > -#!/bin/bash
> > +#!/usr/bin/env bash
> >  #
> >  # Licensed under the terms of the GNU GPL License version 2 or later.
> >  #
> > diff --git a/scripts/pad_image b/scripts/pad_image
> > index 14f1499..b1941a2 100755
> > --- a/scripts/pad_image
> > +++ b/scripts/pad_image
> > @@ -1,4 +1,4 @@
> > -#!/bin/bash
> > +#!/usr/bin/env bash
> >  
> >  function usage {
> >    echo "Usage: prepare_image image_type kernel_image rootfs_image header_size"
> > diff --git a/scripts/redboot-script.pl b/scripts/redboot-script.pl
> > index 123ebe3..e2d1264 100755
> > --- a/scripts/redboot-script.pl
> > +++ b/scripts/redboot-script.pl
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/perl
> > +#!/usr/bin/env perl
> >  #
> >  # Script for generating redboot configs, based on brcmImage.pl
> >  #
> > diff --git a/scripts/remote-gdb b/scripts/remote-gdb
> > index cd59033..5230663 100755
> > --- a/scripts/remote-gdb
> > +++ b/scripts/remote-gdb
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/perl
> > +#!/usr/bin/env perl
> >  
> >  use strict;
> >  use warnings;
> > 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list