[OpenWrt-Devel] [PATCH v3] base-files: evaluate uci-defaults on run-time installations

Hannu Nyman hannu.nyman at iki.fi
Thu Apr 28 02:43:44 EDT 2016

I did not try to think through if this would be the correct thing to do for 
all packages, but the basic change seems reasonable. Having the uci-defaults 
run postponed to the reboot is annoying in some cases.

However, your patch seems to break the basic characteristics of an 
uci-defaults script: The script should be deleted only after being run 
successfully. I think that your patch always deletes the script file, even if 
it fails.

+		( . "$i" )
+		rm "$i"

The original uci-defaults run code deletes the file only after evaluating the 
return value:
( . "./$(basename $file)" ) && rm -f "$file"
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list