[OpenWrt-Devel] [PATCH][CC] Revert "ar71xx: change some TP-link modelnames (WR841, WA701, WA730)"

Sven Roederer devel-sven at geroedel.de
Tue Apr 26 09:02:56 EDT 2016

Am Monday 25 April 2016, 09:06:38 schrieb John Crispin:
> On 25/04/2016 08:54, Bastian Bittorf wrote:
> > * John Crispin <john at phrozen.org> [25.04.2016 07:39]:
> >>> The changed image name breaks compatibility for derived projects and
> >>> that's something which should only happen if there is a really good
> >>> reason (e.g. security fix).
> >> 
> > 
> > I'am against reverting the commit. Lets keep it, because it makes sense.
> > 
> > 
> > bye, bastian
> before i merged the patch i did actually look at the compat issue and
> concluded that only docs will be out of date, which is not really
> anything new. all issues mentioned are home made ones. specially the one
> bastian mentions here. basically fixing your download script and
> deploying it in this way will break forward compat as can be seen here.
> we now face the decision of reverting and unbreaking out of tree issues
> that can be fixed easily or avoided in future or not revert it and keep
> the fix that makes the filenames more consistent. adding the "n" is
> after all correct ad the antenna is not "not" detachable on the relevant
> models.
> 	John

Hi, before I published this patch also for CC I had this in "sideeffect" also 
in mind. As this also forces some changes in the freifunk-berlin scripts, but 
to have a "common name" was our preferred way.
I was also checking before sending this patch for the chances to get applied 
and also during the days the patch was in the "queue" nobody raised the voice. 

So finally, as this change will come, so it comes already inside this release 
and some derived projects also adapted the change.

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list