[OpenWrt-Devel] [PATCH] musl: fix build on sh3

[Felix Fietkau]

On 2015-09-16 09:27, John Crispin wrote:
> Hi,
> 
> On 14/09/2015 10:38, Zoltan HERPAI wrote:
>> musl fails to build when compiled with gcc on sh3 (GCC target/#67260).
>> Work it around.
>> 
>> Signed-off-by: Zoltan HERPAI <wigyori at uid0.hu>
>> ---
>>  toolchain/musl/common.mk |    5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/toolchain/musl/common.mk b/toolchain/musl/common.mk
>> index 82c1543..ba467fb 100644
>> --- a/toolchain/musl/common.mk
>> +++ b/toolchain/musl/common.mk
>> @@ -23,6 +23,11 @@
>> HOST_BUILD_DIR:=$(BUILD_DIR_TOOLCHAIN)/$(PKG_NAME)-$(PKG_VERSION)
>>  include $(INCLUDE_DIR)/toolchain-build.mk
>>  include $(INCLUDE_DIR)/hardening.mk
>> 
>> +ifeq ($(CONFIG_sh3),y)
>> +TARGET_CFLAGS+= \
>> +       -fno-optimize-sibling-calls
>> +endif
>> +
> 
> i am worried that this will be added and never removed as we will forget
> about it. how about making it also depend on the broken gcc version.
There is no non-broken gcc version yet. I think we should at least have
a link to the gcc bug report directly above these lines, so we don't
have to dig through the log to figure out why this was added.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel