[OpenWrt-Devel] [PATCH] oxnas: fix the incorrect board names which cause sysupgrade failed

Daniel Golle daniel at makrotopia.org
Fri Oct 30 06:41:29 EDT 2015


It's already much better. No more white-space or CR-LF brokenness,
we got one step further :)

However, it still can't get merged with git am, because the
mailing-list footer still get's added to the multi-part mime stuff
and that's too much for git to handle.

Sending patches via traditional email is much harder when you are
somewhere in the non-Latin-1/CP437/ISO8859-1 parts of the world (ie.
most of the planet).
Thus, instead of getting into endless fights with email programs and/or
service providers trying to re-format or re-code the message or parts
of it, please simply do this:

cd /home/mike/openwrt/
git format-patch -1 HEAD

this will create 0001-your-patch-title.patch

Attach *that whole file*.
Do *not* strip the From: field or any other RFC822 headers created by
git format-patch.
Do *not* try to send it inline, use it as a draft or template or any
of that because your MUA *will* do bad things to it.
Simply treat it as a binary file and attach it.

Yes, you'll be doing RFC822-over-RFC822, and yes, that's a bit odd,
but seems to be the only way to reliably submit patches if not using
SMTP with git send-email directly (and for that, you need to configure
ssmtp and your email service provider needs to allow you to submit
email via authenticated SMTP).

Sorry about those difficulties, please re-submit in the way described



On Fri, Oct 30, 2015 at 06:22:14PM +0800, 未命名 wrote:
> This patch fix the incorrect board name which cause sysupgrade failed.  The CONTROL file in xxx-squashfs-sysupgrade.tar says BOARD=pogoplug-pro, instead of pogoplugpro. If the text was recode again, i will use other mailbox. Signed-off-by:  Shonn Lu  --- diff --git a/target/linux/oxnas/base-files/etc/board.d/01_leds b/target/linux/oxnas/base-files/etc/board.d/01_leds index 17e37cd..f075764 100755 --- a/target/linux/oxnas/base-files/etc/board.d/01_leds +++ b/target/linux/oxnas/base-files/etc/board.d/01_leds @@ -14,7 +14,7 @@ case $board in  	kd20)  		ucidef_set_led_default "power" "power" "kd20:blue:status" "1"  		;; -	pogoplugpro | pogoplugv3) +	pogoplug-pro | pogoplug-v3)  		ucidef_set_led_default "power" "power" "pogoplug:blue:internal" "1"  		;;   diff --git a/target/linux/oxnas/base-files/etc/diag.sh b/target/linux/oxnas/base-files/etc/diag.sh index 5370696..8f484ae 100644 --- a/target/linux/oxnas/base-files/etc/diag.sh +++ b/target/linux/oxnas/base-files/etc/diag.sh @@ -6,13 +6,13 @@    get_status_led() {  	case $(oxnas_board_name) in -	stg212) +	stg-212)  		status_led="zyxel:blue:status"  		;;  	kd20)  		status_led="kd20:blue:status"  		;; -	pogoplugpro | pogoplugv3) +	pogoplug-pro | pogoplug-v3)  		status_led="pogoplug:blue:internal"  		;;  	esac diff --git a/target/linux/oxnas/base-files/lib/oxnas.sh b/target/linux/oxnas/base-files/lib/oxnas.sh index 1a04d55..2a07928 100755 --- a/target/linux/oxnas/base-files/lib/oxnas.sh +++ b/target/linux/oxnas/base-files/lib/oxnas.sh @@ -14,16 +14,16 @@ oxnas_board_detect() {    	case "$machine" in  	*"MitraStar Technology Corp. STG-212"*) -		name="stg212" +		name="stg-212"  		;;  	*"Shuttle KD20"*)  		name="kd20"  		;;  	*"Pogoplug Pro"*) -		name="pogoplugpro" +		name="pogoplug-pro"  		;;  	*"Pogoplug V3"*) -		name="pogoplugv3" +		name="pogoplug-v3"  		;;  	esac

> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list