[OpenWrt-Devel] [PATCH] Vlan configuration, limit the used ports
zajec5 at gmail.com
Wed May 13 10:39:53 EDT 2015
On 12 May 2015 at 10:16, Hante Meuleman <meuleman at broadcom.com> wrote:
> Do not mimic the vlan configuration in some devices like R8000 as the
> configuration is to be used with SW accelerators not available in OpenWRT.
> It is not possible to use the switch with vlan port configuration 0 1 2 3 5 7 8,
> without making some huge modifications. When this configuration is used
> the packets received will be without vlan tag (identified by status field in
> gmac). This mode is used for an optimization which is not easily to be used
> within the current OpenWRT driver framework.
I think I fixed it now, with indeed few modifications, but not that
huge ones after all. If you could test latest OpenWrt trunk/master it
would be great.
> The patch below will modify the existing vlanport configuration so it will work
> on the r8000 with the existing opensource drivers.
The problem with this patch (apart from S-o-b) was the silent way of
handling R8000. You dropped code that recognized R8000 specific config
just silently falling back to the default one. It would be much safer
to leave R8000 case detection, just change the vlans config and add a
proper comment. Just for the future :)
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel