[OpenWrt-Devel] json-c update

[John Crispin]

On 06/03/2015 14:01, Karl Palsson wrote:
> 
> John Crispin <blogic at openwrt.org> wrote:
>> while doing so i also noticed that the nes jscon-c has a dependency on
>> -lm which i just killed.
> 
> Could you elaborate on this please?  Is this going to remove support for
> int64, or change the behaviour of NaN/Infinite stuff?

i told the code to use the compilers builtins

+#undef isnan
+#define isnan(x) __builtin_isnan(x)
+#undef isinf
+#define isinf(x) __builtin_isinf(x)

plus a bit of wrapper cruft to disable detection in autoconf

funnily the json-c authors decided to use the NAN builtin-in in a
different file, so much for consistency.

> 
>>From the 0.12 changelog, it seems that it _adds_ support for
> NaN/Infinite, is there a particular reason you want to upgrade, but
> don't want to actually get the new features of that upgrade?  For people
> who use json-c in other applications, it would come as a bit of a
> surprise if features expected in a version were simply missing.
> 

as i said, using those 2 wrappers adds a dependency to libm which will
in turn increase the memory footprint as the ldso will load the shared
object etc etc

	John
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel