[OpenWrt-Devel] [PATCH 1/2] sunxi: fix uboot install location

[Zoltan HERPAI]

On Sun, 26 Jul 2015, Zoltan HERPAI wrote:

> On Fri, 24 Jul 2015, John Crispin wrote:
>
>> On 16/07/2015 22:20, Matthias Schiffer wrote:
>>> -BOARDS:= \
>>> -	sun4i-a10-cubieboard \
>>> -	sun4i-a10-olinuxino-lime \
>>> -	sun4i-a10-pcduino \
>>> -	sun5i-a13-olinuxino \
>>> -	sun6i-a31-colombus \
>>> -	sun6i-a31-m9 \
>>> -	sun7i-a20-bananapi \
>>> -	sun7i-a20-bananapro \
>>> -	sun7i-a20-cubieboard2 \
>>> -	sun7i-a20-cubietruck \
>>> -	sun7i-a20-olinuxino-lime \
>>> -	sun7i-a20-olinuxino-micro \
>>> -	sun7i-a20-pcduino3 \
>>> -	sun7i-a20-lamobo-r1
>>> -
>>>  define Image/BuildKernel
>>>  	mkimage -A arm -O linux -T kernel -C none \
>>>  		-a 0x40008000 -e 0x40008000 \
>>>  		-n 'ARM OpenWrt Linux-$(LINUX_VERSION)' \
>>>  		-d $(KDIR)/zImage $(BIN_DIR)/$(IMG_PREFIX)-uImage
>>> -
>>> +
>>>      ifneq ($(CONFIG_TARGET_ROOTFS_INITRAMFS),)
>>>  	$(CP) $(KDIR)/zImage-initramfs 
>>> $(BIN_DIR)/$(IMG_PREFIX)-zImage-initramfs
>>>  	echo -ne '\x00\x00\x00\x00' >> 
>>> $(BIN_DIR)/$(IMG_PREFIX)-zImage-initramfs
>>> @@ -42,27 +26,23 @@ define Image/BuildKernel
>>>  		$(BIN_DIR)/$(IMG_PREFIX)-uImage-initramfs \
>>>  	)
>>>      endif
>>> -
>>> -	$(foreach board,$(BOARDS),
>>> -		$(CP) $(DTS_DIR)/$(board).dtb $(BIN_DIR)/
>>> -	)
>>>  endef
>> 
>> not sure about this change. maybe just stage the dtb file of the
>> selected profile. i am not sure if zoltan added this for a reason.
>
> Thanks John and Matthias for checking on this. I'm offline until the 30th, 
> will get back on this at that time.

Before the sdcard imagebuilder, the dtb files for the supported 
boards were copied to BIN_DIR so the user could pick the correct dtb for 
the board. When the imagebuilder was rolled out, this was not removed 
from the Makefile - now it can go away, so I'm OK with removing this part. 
Although it's a good place to see which boards are supported, there are 
much better ways to do this.

Building boot.img is probably fine to stay in KDIR - that's an interim 
file and not the final image. If you want that changed, please send a v2 - 
if not, I'm happy to apply the series in its current form.

Thanks,
-w-
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel