[OpenWrt-Devel] [PATCH] rampips: Fix pinmux functions for MT7621

Sven Eckelmann sven at open-mesh.com
Fri Jul 31 03:31:14 EDT 2015

On Thursday 30 July 2015 14:23:06 John Crispin wrote:
> On 29/07/2015 17:19, Sven Eckelmann wrote:
> > The pinctrl-rt2880 code doesn't support multiple functions with the same
> > name. This will result in incorrect pinmux configuration.
> > 
> > The MT7621 uses 2 bit wide configuration of the sdhci, spi, mdio, pcie,
> > wdt, uart2 and uart3. But the code only changed a single bit for uart3,
> > uart2 and mdio. Also the order of uart2 and uart3 group was exchanged.
> > 
> > The spi "nand" settings was also reserved only 7 PINs instead of 8 as the
> > spi "spi" setting.
> > 
> i stumbled across this problem on mt7628/88 last few days. the pinctrl
> code was written for a core with 1 bit / function and then grew with new
> socs. i'll try to fix this in the pinctrl driver the next few days
> rather than have redundant function names.

What about the other problems like wrong settings width, wrong settings
position and missing settings? Should I resend them?

Btw. keep in mind that the functions have conflicting settings
(different PINs).

Kind regards,
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list