[OpenWrt-Devel] [PATCH 2/2] Prevent more gzip timestamps

Reiner Herrmann reiner at reiner-h.de
Tue Jul 14 18:05:32 EDT 2015

On Sun, Jul 12, 2015 at 12:06:01PM -0700, Florian Fainelli wrote:
> 2015-07-12 9:41 GMT-07:00 Reiner Herrmann <reiner at reiner-h.de>:
> > To improve reproducibility, prevent the inclusion of timestamps
> > in the gzip header.
> This looks fine to me, this also unveils a lot of repetition in how we
> invoke gzip and its parameters, would you mind factoring this in a
> variable such that we control how gzip options are set globally?
> Eventually someone will want to be able to turn back on timestamps and
> original names in how gzip generates compressed files, and we might as
> well have a single location to fix this.

The commands that are currently available in variables are named
just in uppercase (FIND, TAR, etc.).
But gzip also interprets the variable GZIP to parse additional
options, so naming the variable for the command also GZIP will
probably cause problems.
Or would it be better to just globally export GZIP with the
default parameters (which would then differ from the currents
semantics of having the command inside the variable)?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150715/4096b9ad/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list