[OpenWrt-Devel] [PATCH] fix typo in netifd.sh

John Crispin blogic at openwrt.org
Thu Jan 22 08:41:33 EST 2015



On 20/01/2015 18:44, Cezary Jackiewicz wrote:
> $ht variable is not passed. $htmode is.
> 
> With this, wpa_supplicant-phy0.conf contains htmode line if htmode is set in config.
> 
> Signed-off-by: Cezary Jackiewicz <cezary.jackiewicz at gmail.com>
> ---
> 
> diff --git a/package/network/services/hostapd/files/netifd.sh b/package/network/services/hostapd/files/netifd.sh
> index d625709..436eee3 100644
> --- a/package/network/services/hostapd/files/netifd.sh
> +++ b/package/network/services/hostapd/files/netifd.sh
> @@ -595,8 +595,7 @@ wpa_supplicant_add_network() {
>  		append network_data "mcast_rate=$mc_rate" "$N$T"
>  	}
>  
> -	local ht_str
> -	[ -n "$ht" ] && append network_data "htmode=$ht" "$N$T"
> +	[ -n "$htmode" ] && append network_data "htmode=$htmode" "$N$T"
>  

this patch is wrong for the following reasons

* the htmode values inside netifd-wireless.sh are not the same values
that wpa_supplicant expects
* wpa_supplicant should automagically detect the channel (and the HT40
ext chan)

this leads me to wonder why you need this and an option would be 2 adhoc
clients.

can you explain your wifi setup so that we can figure out how to
properly fix this ?


>  	cat >> "$_config" <<EOF
>  network={
> 
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list