[OpenWrt-Devel] [PATCH, v2] feeds: search packages by license

John Crispin blogic at openwrt.org
Thu Jan 22 03:31:28 EST 2015

On 20/01/2015 23:20, Eric Schultz wrote:
> Currently, the feeds scripts provides no way to filter by packages by license or no license. 
> This patch adds a search feature to feeds which can be used to search packages by license or by no license.
> Calls to script/feeds which do not use the new -l or -n options should work the same as before.
> Signed-off-by: Eric Schultz <eschultz at prplfoundation.org>
> ---


> @@ -642,6 +704,8 @@ Commands:
>  	search [options] <substring>: Search for a package
>  	Options:
>  	    -r <feedname>: Only search in this feed
> +	    -l <license>:  Only include packages with this license
> +	    -n:	           Only include packages without a license tag

i think there parameters are still sub optimal

How about these 2
-l Only include packages with a license
-n List all packages that have no license (developer use)

additionally your text editor seems to be wonky and uses leading spaces
instead of tabs. please make sure you use tabs. I also spotted 2-3
whitespace fixes, these should be in a seperate patch and not
intermingled with the actual feature patch

>  	uninstall -a|<package>: Uninstall a package
>  	Options:
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list