[OpenWrt-Devel] [PATCH] Ar71xx: Add Minibox v1.0 support
karlp at tweak.net.au
Thu Aug 13 09:27:46 EDT 2015
-----BEGIN PGP SIGNED MESSAGE-----
Stijn Segers <francesco.borromini at inventati.org> wrote:
> Hi Karl,
> Thanks for your time.
> I have reworked the patch and re-ordered where possible (files like
> ar71xx.sh and diag.sh lack any alphabetical
> order). I have removed the code that set the led to status_led_off.
> What file should I be looking at, when you talk
> about the board file? Is it the minibox-v1.mk file? I diffed from the
> vendor's code (and added a profile by comparing
> with other devices) but that was it.
I meant target/linux/ar71xx/files/arch/mips/ath79/mach-minibox-v1.c
> I don't have the hardware myself but I have found a tester willing to
> run the image (and see how the LED behaves with
> the default OpenWrt settings).
It's not relevant how it behaves for them on their board. My problem
here was that you were changing the behaviour for _all_ boards. And by
the sound of it, you were working around an active low/high
misconfiguration, which should be addressed by properly configuring the
polarity of the leds in your board file,
> The new patch can be found here:
> If that doesn't work, a backup: http://sprunge.us/AUbX
No-one's looking at that. I'm being helpful by reviewing your earlier
mangled patch, but if you want this to be applied, you _will_ need to
Pay particular attention to item 6. Yes, this is the graybeard stone
age, lowest common denominator of email behaviour, but those are the
_rules_ I recommend git-send-email to avoid the mangling that most clients will do.
I expect the problem here: https://patchwork.ozlabs.org/patch/505479/
was that you trying to use diff manually to generate the patch set (from
your .orig directory) While I'm sure that's possible, there's a reason
most people use git or svn.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
-----END PGP SIGNATURE-----
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel