[OpenWrt-Devel] [PATCH] [uci] luci-upnp Remove upnp service disable on upgrade

Kevin Darbyshire-Bryant kevin at darbyshire-bryant.me.uk
Sat Apr 25 06:53:43 EDT 2015

Current behaviour on system upgrade is to disabled the 'upnpd' service on first boot.  This was originally implemented
in 2008 (https://github.com/openwrt/luci/commit/66fa0eb0e8e206d26e16615941c60b22b5004649) as a security

The 'auto disable' function only occurs on first boot after an upgrade and only if the luci-upnp package is installed.
In all other cases auto disabling of 'upnpd/miniupnpd' service does not occur.  This is inconsistent & confusing, not
only in user interface/state handling but also in security.
a) disable the service at first boot after upgrade in all cases
b) Treat upnp like any other service on the router, leaving it in its configured state across upgrades, whether luci-upnp
package is installed or not.
c) Consider disabling all optional services across upgrade (transmission, samba, asterisk, etc...)

The patch takes option b) and stops luci-upnp from disabling the service on first boot after an upgrade.

Signed-off-by: Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk>

diff --git a/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp b/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
deleted file mode 100755
index fe22a3e..0000000
--- a/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
+++ /dev/null
@@ -1,9 +0,0 @@
-/etc/init.d/miniupnpd enabled && {
-    /etc/init.d/miniupnpd stop
-    /etc/init.d/miniupnpd disable
-rm -f /tmp/luci-indexcache
-exit 0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4791 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150425/d9521637/attachment.p7s>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list