[OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support
blogic at openwrt.org
Tue Apr 14 11:51:50 EDT 2015
>>> + if (!S_ISREG(s.st_mode))
>>> + return UBUS_STATUS_NOT_SUPPORTED;
>> should this not be -> UBUS_STATUS_INVALID_ARGUMENT
> I think "not supported" in response to "md5sum of a non-regular file"
> (like a chardev or directory) makes sense here - imho.
your codebase, so your call :-) i'll merge it as is then if that is fine
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel