[OpenWrt-Devel] [PATCH 3/3] [V2] netifd: Read current link state when processing netlink event

Felix Fietkau nbd at openwrt.org
Fri Oct 24 13:51:41 EDT 2014

On 2014-10-23 11:13, Hans Dedecker wrote:
> Netifd commit b2dcb02570939d98b92c7c55db1c328693a5d52a introduces
> a race condition resulting into infinite toggling interfaces
> (eg static interfaces with linksensing enabled, vlan interfaces
> with proto none (#18106)) when linksensing is enabled resulting into
> a crash.
> As netlink event messages will be queued on the netlink event socket
> the included lower up interface flag will not always represent the
> current link state when netifd processes the netlink messages;
> by reading the current link state when a netlink event message is
> parsed the correct info is passed to the device layer.
> This will avoid continuous interface toggling (down/up) triggered
> by link state changes based on outdated netlink interface info.
> Signed-off-by: Hans Dedecker <dedeckeh at gmail.com>
Looks good, pushed to git.


- Felix
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list