[OpenWrt-Devel] [PATCH] comgt: add ncm proto support

[Bjørn Mork]

"Conor O'Gorman" <i at conorogorman.net> writes:
> On 09/10/14 13:25, John Crispin wrote:
>>
>> personally i have been using mbim since i wrote umbim and it just works :)
>>
>
> Ah, nice. I have some similar code, but in lua, from the json
> files. It's only a management protocol.
>
> Note that MBIM uses the NCM code for the bulk packet data, so it's
> packetising is still in play.

Except that bugs in some MBIM implementations forced us to change the
default to always send ZLPs for MBIM devices.  See the comment starting
at 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/usb/cdc_mbim.c#n561

And since the padding is pointless if followed by a ZLP, it was disabled
for all devices where we send ZLPs:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/usb/cdc_ncm.c#n1162

So effectively:  No, we do not do the padding for (most) MBIM devices.

Hmm, except that this was changed sometime between 3.10 and 3.14.  So if
we are talking about 3.10 then we do pad for MBIM too, yes.


Bjørn
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel