[OpenWrt-Devel] OM2P firmware upgrade with LuCI

Bruno Randolf br1 at einfach.org
Fri Nov 28 16:20:05 EST 2014


I just noted that there is an issue with the firmware upgrade via LuCI
on the OM2P. The image validity check fails, because the following
script in system.lua fails:

	local function image_supported()
		-- XXX: yay...
		return ( 0 == os.execute(
			". /lib/functions.sh; " ..
			"include /lib/upgrade; " ..
			"platform_check_image %q >/dev/null"
				% image_tmp
		) )

Calling "platform_check_image" directly fails due to the way
target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh is written
("break"), but I believe the better way would be to use "sysupgrade -T"
anyhow - it works if I change the code like this:

	local function image_supported()
		return ( 0 == os.execute(
			"sysupgrade -T %q >/dev/null"
				% image_tmp
		) )

Any chance to get this into LuCI or should /lib/upgrade/openmesh.sh be
rewritten to be compatible with the ("yay") LuCI way?

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list