[OpenWrt-Devel] protobuf broken in BB (was: Fwd: [PATCH] [packages] protobuf: Bump version, fix build errors.)

[Guillaume Déflache]

Hi all

[As I am not sure Jacob and Obinou (the package's registered maintainer) 
are the same person (are they?), I am trying to CC to both too...]


We are actually trying migrating from a few-months-old trunk snapshot to 
the official Barrier Breaker release, and on BB protobuf does not work 
anymore.

A workaround that got protoc to be copied at the right place (and e.g. 
allowed CMake to find it) was to go to the host build directory and to 
do a `make install` from here.
In other words:
	$(MAKE) -C $(HOST_BUILD_DIR) install

AFAICU the problem was introduced in the attached patch by adding 
explicit host macro definitions:

 > @@ -37,7 +37,14 @@ define Package/protobuf/description
 >    of its internal RPC protocols and file formats.
 >   endef
 >
 > -CONFIGURE_ARGS += --with-protoc=$(STAGING_DIR_HOST)/bin/protoc
 > +define Host/Compile
 > +	$(MAKE) -C $(HOST_BUILD_DIR)
 > +endef
 > +
 > +define Host/Install
 > +endef
 > +
 > +CONFIGURE_ARGS += --with-protoc=$(HOST_BUILD_DIR)/src/protoc
 >
 >   define Build/InstallDev
 >   	$(INSTALL_DIR) \
 >

Did that have to be changed for 2.5.0 (from 2.4.1)? What was the need?


Cheers,
    Guillaume
-- 
ibw ag software, Aarestrasse 17, CH-5412 Vogelsang, http://www.ibwag.com
Guillaume Déflache, Projektingenieur, Telefon: +41 56 201 07 30


---
Diese E-Mail ist frei von Viren und Malware, denn der avast! Antivirus Schutz ist aktiv.
http://www.avast.com
-------------- next part --------------
An embedded message was scrubbed...
From: Jacob Siverskog <jacob at teenageengineering.com>
Subject: [PATCH] [packages] protobuf: Bump version,	fix build errors.
Date: Fri, 13 Jun 2014 08:37:33 +0200
Size: 4696
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20141105/e05589d4/attachment.eml>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel