[OpenWrt-Devel] [PATCH 3/4] ramips: squelch mdio debugging info on rt2880 ethernet

[Claudio Leite]

Hello,

* Claudio Leite (leitec at staticky.com) wrote:
> Use pr_debug rather than pr_info since it is only relevant
> for debugging.
> 
> Signed-off-by: Claudio Leite <leitec at staticky.com>

While we are talking about things for Barrier Breaker RC's, could this
patch be merged in? It was marked as accepted back in April, but I just
tested the RC1 release on a RT2880 board and it still has the mdio r/w
dumps.

While it doesn't affect actual performance, it does slow down boot by
a few seconds while it programs the switch.

> ---
>  .../0220-NET-ralink-squelch_mdio_access.patch      | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 target/linux/ramips/patches-3.10/0220-NET-ralink-squelch_mdio_access.patch
> 
> diff --git a/target/linux/ramips/patches-3.10/0220-NET-ralink-squelch_mdio_access.patch b/target/linux/ramips/patches-3.10/0220-NET-ralink-squelch_mdio_access.patch
> new file mode 100644
> index 0000000..bc92a02
> --- /dev/null
> +++ b/target/linux/ramips/patches-3.10/0220-NET-ralink-squelch_mdio_access.patch
> @@ -0,0 +1,22 @@
> +Index: linux-3.10.34/drivers/net/ethernet/ralink/mdio_rt2880.c
> +===================================================================
> +--- linux-3.10.34.orig/drivers/net/ethernet/ralink/mdio_rt2880.c
> ++++ linux-3.10.34/drivers/net/ethernet/ralink/mdio_rt2880.c
> +@@ -136,7 +136,7 @@ int rt2880_mdio_read(struct mii_bus *bus
> + 	if (err)
> + 		return 0xffff;
> + 
> +-	pr_info("%s: addr=%04x, reg=%04x, value=%04x\n", __func__,
> ++	pr_debug("%s: addr=%04x, reg=%04x, value=%04x\n", __func__,
> + 		phy_addr, phy_reg, fe_r32(FE_MDIO_ACCESS) & 0xffff);
> + 
> + 	return fe_r32(FE_MDIO_ACCESS) & 0xffff;
> +@@ -148,7 +148,7 @@ int rt2880_mdio_write(struct mii_bus *bu
> + 	int err;
> + 	u32 t;
> + 
> +-	pr_info("%s: addr=%04x, reg=%04x, value=%04x\n", __func__,
> ++	pr_debug("%s: addr=%04x, reg=%04x, value=%04x\n", __func__,
> + 		phy_addr, phy_reg, fe_r32(FE_MDIO_ACCESS) & 0xffff);
> + 
> + 	err = rt2880_mdio_wait_ready(priv);
> -- 
> 1.8.2.1

Thanks.
-Claudio
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel