[OpenWrt-Devel] [Patch][BCM63XX][V2][RFC] Select HW_RANDOM_BCM63XX only in the SoCs that support it.

[José Vázquez]

2014-07-01 0:57 GMT+02:00, Florian Fainelli <florian at openwrt.org>:
> 2014-06-30 4:30 GMT-07:00 José Vázquez <ppvazquezfer at gmail.com>:
>> b43 and b43-legacy drivers enable CONFIG_HW_RANDOM in
>> .config.override; without they selected the "problem" does not happen.
>> More drivers need HW_RANDOM but they were not selected in my owrt
>> config.
>>
>> define KernelPackage/b43
>>   $(call KernelPackage/mac80211/Default)
>>   TITLE:=Broadcom 43xx wireless support
>>   URL:=http://linuxwireless.org/en/users/Drivers/b43
>>   KCONFIG:= \
>>         CONFIG_HW_RANDOM=y
>>
>> I have no idea why these drivers enable HW_RANDOM but surely there is
>> a good reason.
>
> I think this is just from a time where there was not a package for
> HW_RANDOM, you might want to make b43 depend on that specific kmod
> package that would be cleaner in any case.
I think that an additional option should be added in both b43 drivers
in order to have the choice of select or unselect B43_HWRNG because
BCM4318, BCM43222 and BCM43225 don't pass rng-tools fips tests (maybe
other BCM wireless chips pass them).
http://lxr.free-electrons.com/source/drivers/net/wireless/b43/Kconfig?v=3.10#L155
>
>>
>> A lot of thanks for your time and guidance.
>
> And thanks for your perseverance, that is much appreciated!
If my perseverance is useful, perfect, but if not, my apologies.
> --
> Florian
>
Excuse me if i don't fully understood your comment; what do you want
to mean with "I think this is just from a time where there was not a
package for HW_RANDOM"? My english is still a bit poor.

Best regards:

Pepe
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel