[OpenWrt-Devel] Announcement of mac80211 driver support for Marvell 88W8864 chip

Jiri Pirko jiri at resnulli.us
Wed Dec 31 13:54:40 EST 2014

Wed, Dec 24, 2014 at 05:04:29PM CET, dlin at marvell.com wrote:
>Hi all,
>Marvell is pleased to announce this open source driver for the 88W8864 chip as a joint effort with Linksys.  The 88W8864 features 4x4 MIMO 3-spatial Stream Dual-band 802.11ac enabling 1.3Gbps WLAN PHY rate and support for 80/40/20 MHz channel bandwidths. The 88W8864 is used in the Linksys WRT1900AC and other products.
>Please note that this is an initial release and we plan to send the driver upstream after cleanup.
>We do appreciate your feedback and look forward to serving the community with exciting new offerings in the future!


I took a very quick peek at the sources you sent.

First I would like to thank you for taking the upstream way with this.
Much appreciated.

I would suggest you to develop your driver inside net-next git:

That would save you time during potential forward port need.

Also, if you use scripts/checkpatch.pl script to check your patches, it
will reveal many problems to you. The obvious one is lines longer than 80

It is always nice to include all needed headers in all .c files. For
example when you use skb_queue_head_init please include <linux/skbuff.h>

Spotted a comment typo in mwl_fwdl.c:
"This file implements frimware downloa related functions"

Drop comments like:
Not needed.

"MODULE_" macros are usually placed by the end of file.

Module parameters should be always avoided if possible.

I suggest you make patch against net-next and send it on
linux-wireless at vger.kernel.org and netdev at vger.kernel.org mailing lists.
You will get much more reviewers there.

Please do not hesitate to email me in case I can be of any more help.



>Thanks, David

>openwrt-devel mailing list
>openwrt-devel at lists.openwrt.org
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list