[OpenWrt-Devel] [PATCH 2/3] json_script: fix logic invert of handle_expr_not().

Yousong Zhou yszhou4tech at gmail.com
Tue Dec 16 16:15:36 EST 2014


Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
---
 json_script.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/json_script.c b/json_script.c
index 6a17d3b..73c2502 100644
--- a/json_script.c
+++ b/json_script.c
@@ -333,12 +333,16 @@ static int handle_expr_or(struct json_call *call, struct blob_attr *expr)
 static int handle_expr_not(struct json_call *call, struct blob_attr *expr)
 {
 	struct blob_attr *tb[3];
+	int ret;
 
 	json_get_tuple(expr, tb, BLOBMSG_TYPE_ARRAY, 0);
 	if (!tb[1])
 		return -1;
 
-	return json_process_expr(call, tb[1]);
+	ret = json_process_expr(call, tb[1]);
+	if (ret < 0)
+		return ret;
+	return !ret;
 }
 
 static const struct json_handler expr[] = {
-- 
1.7.10.4
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list