[OpenWrt-Devel] [PATCH] ar71xx: make LED names for EnGenius routers follow convention

Yousong Zhou yszhou4tech at gmail.com
Wed Aug 20 21:24:08 EDT 2014


On 21 August 2014 06:45, Forest Crossman <cyrozap at gmail.com> wrote:
> Signed-off-by: Forest Crossman <cyrozap at gmail.com>
> ---
>  target/linux/ar71xx/base-files/etc/diag.sh                |  4 ++--
>  target/linux/ar71xx/base-files/etc/uci-defaults/01_leds   |  8 ++++----
>  target/linux/ar71xx/files/arch/mips/ath79/mach-eap300v2.c |  6 +++---
>  target/linux/ar71xx/files/arch/mips/ath79/mach-esr900.c   | 10 +++++-----
>  4 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/target/linux/ar71xx/base-files/etc/diag.sh b/target/linux/ar71xx/base-files/etc/diag.sh
> index 1864b11..0401b93 100755
> --- a/target/linux/ar71xx/base-files/etc/diag.sh
> +++ b/target/linux/ar71xx/base-files/etc/diag.sh
> @@ -63,7 +63,7 @@ get_status_led() {
>                 status_led="d-link:amber:power"
>                 ;;
>         eap300v2)
> -               status_led="engenius:blue:power"
> +               status_led="eap300v2:blue:power"
>                 ;;

Taking those buffalo, d-link and other routers as examples, I thought
the convention for naming leds should be `$brand:$color:$function".


                yousong
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list