[FS#3901] WPA encryption broken since commit "mac80211: remove patches stripping down crypto support"

[OpenWrt Bugs]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#3901 - WPA encryption broken since commit "mac80211: remove patches stripping down crypto support"
User who did this - kestrel1974 (kestrel1974)

----------
(copy of the comment in the commit to disable ltq-deu) I had a look at the driver in trunk and could reproduce the issue by using mac80211_hwsim on fritzbox 7490 even without a physical wifi. While removing the driver or commenting out AES makes this issue go away, the drivers AES methods (aes_set_key) are not even called when the error occurs. They are called, when the error does not occur, e.g. I added printk and dumpstack() to the methods in ifxmips_aes.c and in some cases the error went away and the virtual wlan0 and wlan1 initialized just fine. There is a __'netifd: radio0 (2354): Command failed: Invalid argument'__ error from netifd in the log, so to me it seems the actual error is caused before even calling the ltq-deu drivers set_key method:

Fri Jul  2 19:51:13 2021 daemon.err hostapd: nl80211: kernel reports: key addition failed
Fri Jul  2 19:51:13 2021 daemon.err hostapd: Interface initialization failed
Fri Jul  2 19:51:13 2021 daemon.notice hostapd: wlan0: interface state UNINITIALIZED->DISABLED
Fri Jul  2 19:51:13 2021 daemon.notice hostapd: wlan0: AP-DISABLED
Fri Jul  2 19:51:13 2021 daemon.err hostapd: wlan0: Unable to setup interface.
Fri Jul  2 19:51:13 2021 daemon.notice hostapd: nl80211: deinit ifname=wlan0 disabled_11b_rates=0
Fri Jul  2 19:51:13 2021 kern.info kernel: [   87.629502] device wlan0 left promiscuous mode
Fri Jul  2 19:51:13 2021 kern.info kernel: [   87.632878] br-lan: port 6(wlan0) entered disabled state
Fri Jul  2 19:51:13 2021 daemon.notice hostapd: wlan0: CTRL-EVENT-TERMINATING
Fri Jul  2 19:51:13 2021 daemon.err hostapd: hostapd_free_hapd_data: Interface wlan0 wasn't started
Fri Jul  2 19:51:13 2021 daemon.notice netifd: radio0 (2354): Command failed: Invalid argument
Fri Jul  2 19:51:13 2021 daemon.err hostapd: Interface initialization failed
Fri Jul  2 19:51:13 2021 daemon.notice netifd: radio0 (2354): Device setup failed: HOSTAPD_START_FAILED

Unfortunately I have no clue, which command and which argument failed.
The behaviour on real hardware might be different, since as mentioned sometimes I could bring up wlan0 and wlan1 just by adding printk to the aes_set_key method and there were cases, when commenting out the printk and rebuilding the initramfs image did not make the error appear again. For the log to capture I have to delete the ltq-deu directory in the build_dir in order to make the error appear again. I wonder if its a timing issue in the startup scripts or who knows.

----------

More information can be found at the following URL:
https://bugs.openwrt.org/index.php?do=details&task_id=3901#comment9888

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.