[FS#3730] resolve_conffiles reports spurious errors

[OpenWrt Bugs]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#3730 - resolve_conffiles reports spurious errors
User who did this - Nick (kousu)

----------
On ucitrack, the first prototype works directly,


root at router:~# uci show ucitrack > /tmp/b
root at router:~# uci show ucitrack-opkg | sed 's/-opkg//' > /tmp/a
root at router:~# diff -u /tmp/a /tmp/b
--- /tmp/a	2021-04-08 11:32:41.281049289 -0400
+++ /tmp/b	2021-04-08 11:32:03.460601813 -0400
@@ -1,11 +1,11 @@
 ucitrack. at network[0]=network
 ucitrack. at network[0].init='network'
-ucitrack. at network[0].affects='dhcp'
+ucitrack. at network[0].affects='dhcp' 'radvd'
 ucitrack. at wireless[0]=wireless
 ucitrack. at wireless[0].affects='network'
 ucitrack. at firewall[0]=firewall
 ucitrack. at firewall[0].init='firewall'
-ucitrack. at firewall[0].affects='luci-splash'
+ucitrack. at firewall[0].affects='luci-splash' 'qos' 'miniupnpd' 'sqm'
 ucitrack. at olsr[0]=olsr
 ucitrack. at olsr[0].init='olsrd'
 ucitrack. at dhcp[0]=dhcp
@@ -24,9 +24,9 @@
 ucitrack. at system[0]=system
 ucitrack. at system[0].init='led'
 ucitrack. at system[0].exec='/etc/init.d/log reload'
-ucitrack. at system[0].affects='luci_statistics'
+ucitrack. at system[0].affects='luci_statistics' 'dhcp'
 ucitrack. at luci_splash[0]=luci_splash
-ucitrack. at luci_splash[0].init=''\''luci_splash'\'''
+ucitrack. at luci_splash[0].init='luci_splash'
 ucitrack. at upnpd[0]=upnpd
 ucitrack. at upnpd[0].init='miniupnpd'
 ucitrack. at ntpclient[0]=ntpclient
@@ -35,3 +35,7 @@
 ucitrack. at samba[0].init='samba'
 ucitrack. at tinyproxy[0]=tinyproxy
 ucitrack. at tinyproxy[0].init='tinyproxy'
+ucitrack. at sqm[0]=sqm
+ucitrack. at sqm[0].init='sqm'
+ucitrack. at luci_statistics[0]=luci_statistics
+ucitrack. at luci_statistics[0].init='luci_statistics'


but I is harder to apply back to the actual system because it doesn't give me mergeable config files directly. Unfortunately my second prototype didn't work too well on ucitrack:


root at router:~# uci show ucitrack-opkg | xargs -n 1 uci set && uci commit
uci: Entry not found
uci: Entry not found
uci: Entry not found
uci: Invalid argument


I think this is probably because this file uses this syntax which can be misinterpreted by the shell:


root at router:~# uci show ucitrack-opkg
ucitrack-opkg. at network[0]=network
ucitrack-opkg. at network[0].init='network'
ucitrack-opkg. at network[0].affects='dhcp'
ucitrack-opkg. at wireless[0]=wireless
[...]
ucitrack-opkg. at samba[0]=samba
ucitrack-opkg. at samba[0].init='samba'
ucitrack-opkg. at tinyproxy[0]=tinyproxy
ucitrack-opkg. at tinyproxy[0].init='tinyproxy'



So here's a second revision of my second prototype using `uci batch`:


root at router:~# uci show ucitrack-opkg | sed 's/^/set /' | uci batch
root at router:~# uci changes
ucitrack-opkg.cfg0102af='network'
ucitrack-opkg.cfg02e233='wireless'
ucitrack-opkg.cfg03b57b='firewall'
ucitrack-opkg.cfg04c845='olsr'
ucitrack-opkg.cfg05ad04='dhcp'
ucitrack-opkg.cfg06f057='odhcpd'
ucitrack-opkg.cfg074dd4='dropbear'
ucitrack-opkg.cfg088cc9='httpd'
ucitrack-opkg.cfg09cd75='fstab'
ucitrack-opkg.cfg0aa258='qos'
ucitrack-opkg.cfg0be48a='system'
ucitrack-opkg.cfg0c003c='luci_splash'
ucitrack-opkg.cfg0d804c='upnpd'
ucitrack-opkg.cfg0e8036='ntpclient'
ucitrack-opkg.cfg0f0f89='samba'
ucitrack-opkg.cfg10822b='tinyproxy'
root at router:~# uci commit



root at router:~# diff -u /etc/config/ucitrack-opkg /etc/config/ucitrack
--- /etc/config/ucitrack-opkg	2021-04-08 11:39:20.000000000 -0400
+++ /etc/config/ucitrack	2021-04-08 10:18:05.000000000 -0400
@@ -1,21 +1,25 @@
 
 config network
 	option init 'network'
-	option affects 'dhcp'
+	list affects 'dhcp'
+	list affects 'radvd'
 
 config wireless
-	option affects 'network'
+	list affects 'network'
 
 config firewall
 	option init 'firewall'
-	option affects 'luci-splash'
+	list affects 'luci-splash'
+	list affects 'qos'
+	list affects 'miniupnpd'
+	list affects 'sqm'
 
 config olsr
 	option init 'olsrd'
 
 config dhcp
 	option init 'dnsmasq'
-	option affects 'odhcpd'
+	list affects 'odhcpd'
 
 config odhcpd
 	option init 'odhcpd'
@@ -35,10 +39,11 @@
 config system
 	option init 'led'
 	option exec '/etc/init.d/log reload'
-	option affects 'luci_statistics'
+	list affects 'luci_statistics'
+	list affects 'dhcp'
 
 config luci_splash
-	option init ''\''luci_splash'\'''
+	option init 'luci_splash'
 
 config upnpd
 	option init 'miniupnpd'
@@ -52,3 +57,9 @@
 config tinyproxy
 	option init 'tinyproxy'
 
+config sqm
+	option init 'sqm'
+
+config luci_statistics
+	option init 'luci_statistics'
+



I now aspire the patch to be adding


uci show $PKG-opkg | sed 's/^/set /' | uci batch && uci commit


into resolve_conffiles.
----------

More information can be found at the following URL:
https://bugs.openwrt.org/index.php?do=details&task_id=3730#comment9553

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.