[FS#3721] custom "CONFIG_VERSION_DIST" breaks building Edimax images

[OpenWrt Bugs]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Sven Roederer (SAm0815) 

Attached to Project - OpenWrt/LEDE Project
Summary - custom "CONFIG_VERSION_DIST" breaks building Edimax images
Task Type - Bug Report
Category - Base system
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Medium
Priority - Very Low
Reported Version - Trunk
Due in Version - Undecided
Due Date - Undecided
Details - Just ran a custom build for ath79  with setting CONFIG_VERSION_DIST="Roederer" finally fails in target/linux/install with


/mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/staging_dir/host/bin/edimax_fw_header -M F9J1108v1 -m BR-6679BAC -v Roedererr15865 -n "uImage" -i /mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/loader-belkin_f9j1108-v2.uImage -o /mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/tmp/roederer-2021.04-1faf8bcb-ath79-generic-belkin_f9j1108-v2-squashfs-factory.bin.uImage
[edimax_fw_header] *** error: 'Roedererr15865' is too long, max firware version length is 13
Makefile:87: recipe for target '/mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/tmp/roederer-2021.04-1faf8bcb-ath79-generic-belkin_f9j1108-v2-squashfs-factory.bin' failed
make[5]: *** [/mnt/hosts/strike/develop/sven/openwrt/freifunk/freifunk-berlin/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/tmp/roederer-2021.04-1faf8bcb-ath79-generic-belkin_f9j1108-v2-squashfs-factory.bin] Error 255


So the VERSION_DIST gets suffixed by "r15865" which make it 14 bytes long. With the default "OpenWrt" it will be excatly 13 bytes.

Not sure what's the best fix:

  * limiting the max length of the CONFIG-option
  * stripping something from the vesion-string provided to the edimax_fw_header command
  * chopping the extra bytes


This was actually seen in OpenWrt-21.02, but the Makefile seems identical to master.
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ath79/image/generic.mk;h=f358d44064438c2aad4cf45840dee40f5381b2fe;hb=refs/heads/master#l55


More information can be found at the following URL:
https://bugs.openwrt.org/index.php?do=details&task_id=3721

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.