[FS#3149] pppoe-only-process-padt-targeted-at-local-interfaces.patch

[OpenWrt Bugs]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#3149 - pppoe-only-process-padt-targeted-at-local-interfaces.patch
User who did this - David Balažic (xerces8)

----------
Note that 4.14 was also patched:

[PATCH 4.14 06/46] pppoe: only process PADT targeted at local interfaces
From: Greg Kroah-Hartman 
Tue, 9 Jun, 19:49
	
to linux-kernel, Greg, stable, me, Guillaume, David


From: Guillaume Nault 

We don't want to disconnect a session because of a stray PADT arriving
while the interface is in promiscuous mode.
Furthermore, multicast and broadcast packets make no sense here, so
only PACKET_HOST is accepted.

Reported-by: David Balažic 
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller 
---
 drivers/net/ppp/pppoe.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index fa7121dcab67..202a0f415e1e 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -497,6 +497,9 @@ static int pppoe_disc_rcv(struct sk_buff *skb, struct net_device *dev,
        if (!skb)
                goto out;

+       if (skb->pkt_type != PACKET_HOST)
+               goto abort;
+
        if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr)))
                goto abort;

----------

More information can be found at the following URL:
https://bugs.openwrt.org/index.php?do=details&task_id=3149#comment8875

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.