[PATCH v1] meson saradc: fix clock divider mask length

Vyacheslav adeep at lexina.in
Wed May 17 04:37:37 PDT 2023


Hi, Martin,

On 16.05.2023 22:08, Martin Blumenstingl wrote:
> Hi George,
> 
> thank you for this patch!
> 
> On Mon, May 15, 2023 at 11:06 PM George Stark <gnstark at sberdevices.ru> wrote:
>>
>> From: George Stark <GNStark at sberdevices.ru>
>>
>> According to datasheets of supported meson SOCs
>> length of ADC_CLK_DIV field is 6 bits long
> I have a question about this sentence which doesn't affect this patch
> - it's only about managing expectations:
> Which SoC are you referring to?

I checked the 905x, 905x3, a113x datasheets - there is the same register 
with 6 bits for  ADC_CLK_DIV

> This divider is only relevant on older SoCs that predate GXBB (S905).
> To my knowledge all SoCs from GXBB onwards place the divider in the
> main or AO clock controller, so this bitmask is irrelevant there.
> 
>> Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs")
>> Signed-off-by: George Stark <GNStark at sberdevices.ru>
> Since my question above doesn't affect this patch:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

-- 
Vyacheslav Bocharov



More information about the linux-arm-kernel mailing list